Fix setting the current progress for an indeterminate bar

CHANGELOG.md

@@ -1,5 +1,11 @@
 # Change log
 
+## Unreleased
+
+### Fixed
+* Fix setting the current progress for an indeterminate bar by Alex Watt
+  (@alexcwatt)
+
 ## [v0.18.2] - 2021-03-08
 
 ### Fixed

lib/tty/progressbar.rb

@@ -290,7 +290,12 @@ def update(options = {})
     #
     # @api public
     def current=(value)
-      value = [0, [value, total].min].max
+      unless value.is_a?(Numeric)
+        raise ArgumentError, "Expected a numeric value, " \
+                             "got #{value.inspect} instead."
+      end
+
+      value = [0, [value, total].compact.min].max
       advance(value - @current)
     end
 

spec/unit/set_current_spec.rb

@@ -33,6 +33,17 @@
     expect(progress.current).to eq(0)
   end
 
+  it "doesn't allow nil" do
+    progress = TTY::ProgressBar.new("[:bar]", output: output, total: 10)
+    expect {
+      progress.current = nil
+    }.to raise_error(
+      ArgumentError,
+      "Expected a numeric value, got nil instead."
+    )
+    expect(progress.current).to eq(0)
+  end
+
   it "cannot backtrack on finished" do
     progress = TTY::ProgressBar.new("[:bar]", output: output, total: 10)
     progress.current = 10
@@ -42,4 +53,10 @@
     output.rewind
     expect(output.read).to eq("\e[1G[==========]\n")
   end
+
+  it "allows setting progress when the total is unknown" do
+    progress = TTY::ProgressBar.new("[:bar]", output: output, total: nil)
+    progress.current = 5
+    expect(progress.current).to eq(5)
+  end
 end