Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update base image and action.yaml(add piped-handle-timeout input) #16

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

mi11km
Copy link
Contributor

@mi11km mi11km commented Nov 14, 2023

What this PR does / why we need it:
The actions-plan-preview supports timeout option.
However, the actions-plan-preview finished in 5m (default timeout minutes) although setting 15m in timeout option.
Here is the actual actions logs:
スクリーンショット 2023-11-02 午後12 14 14
スクリーンショット 2023-11-02 午後2 07 55

To make the timeout option work, use -piped-handle-timeout when executing pipectl.

Related PRs:
pipe-cd/pipecd#4648

Does this PR introduce a user-facing change?: Yes

Signed-off-by: mi11km <mi11km.program@gmail.com>
@mi11km mi11km force-pushed the update-actions-plan-preview-version branch from 0bf9beb to 717bda6 Compare November 14, 2023 02:28
Signed-off-by: mi11km <mi11km.program@gmail.com>
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you 🫡

@khanhtc1202 khanhtc1202 merged commit 8ea5174 into pipe-cd:main Nov 14, 2023
1 check passed
@mi11km mi11km deleted the update-actions-plan-preview-version branch November 14, 2023 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants