-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a bug that causes piped crashes while rolling back #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pipecd-bot
reviewed
Aug 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code coverage for golang is
|
nakabonne
reviewed
Aug 13, 2020
nakabonne
reviewed
Aug 13, 2020
Code coverage for golang is
|
Other than some nits, looks good to me. |
Co-authored-by: Ryo Nakao <ryo@nakao.dev>
/approve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Scenario:
K8S_SYNC
) is cancelled from web UI whileensurePreparing
is runningprepareOnce
is marked as executed buts.deploymentConfig = cfg
is still not configuredprepareOnce
was marked as executed sos.deploymentConfig
is still nils.deploymentConfig
in rollback executionWhich issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:
/cc @nakabonne