-
Notifications
You must be signed in to change notification settings - Fork 156
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix a bug that causes piped crashes while rolling back (#617)
**What this PR does / why we need it**: Scenario: - A deployment is triggered - The first stage (e.g. `K8S_SYNC`) is cancelled from web UI while `ensurePreparing` is running - So `prepareOnce` is marked as executed but `s.deploymentConfig = cfg` is still not configured - The rollback stage starts running - Because the `prepareOnce` was marked as executed so `s.deploymentConfig` is still nil - That causes a panic when accessing `s.deploymentConfig` in rollback execution **Which issue(s) this PR fixes**: Fixes # **Does this PR introduce a user-facing change?**: <!-- If no, just write "NONE" in the release-note block below. --> ```release-note NONE ``` /cc @nakabonne This PR was merged by Kapetanios.
- Loading branch information
Showing
1 changed file
with
46 additions
and
50 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters