Revert "Fix resource key to keep compatibility"

Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> This reverts commit 098d1da.
pipe-cd · Dec 18, 2024 · 057b9f5 · 057b9f5
1 parent 63c8d77
commit 057b9f5
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 10 deletions.
diff --git a/pkg/app/pipedv1/plugin/kubernetes/provider/loader_test.go b/pkg/app/pipedv1/plugin/kubernetes/provider/loader_test.go
@@ -60,7 +60,6 @@ metadata:
 					Key: ResourceKey{
 						APIVersion: "v1",
 						Kind:       "ConfigMap",
-						Namespace:  "default",
 						Name:       "test-config",
 					},
 					Body: &unstructured.Unstructured{
@@ -94,7 +93,6 @@ metadata:
 					Key: ResourceKey{
 						APIVersion: "v1",
 						Kind:       "ConfigMap",
-						Namespace:  "default",
 						Name:       "test-config",
 					},
 					Body: &unstructured.Unstructured{
@@ -111,7 +109,6 @@ metadata:
 					Key: ResourceKey{
 						APIVersion: "v1",
 						Kind:       "Service",
-						Namespace:  "default",
 						Name:       "test-service",
 					},
 					Body: &unstructured.Unstructured{
@@ -194,7 +191,6 @@ metadata:
 					Key: ResourceKey{
 						APIVersion: "v1",
 						Kind:       "ConfigMap",
-						Namespace:  "default",
 						Name:       "test-config",
 					},
 					Body: &unstructured.Unstructured{
@@ -237,7 +233,6 @@ metadata:
 					Key: ResourceKey{
 						APIVersion: "v1",
 						Kind:       "Service",
-						Namespace:  "default",
 						Name:       "test-service",
 					},
 					Body: &unstructured.Unstructured{
@@ -279,7 +274,6 @@ metadata:
 					Key: ResourceKey{
 						APIVersion: "v1",
 						Kind:       "ConfigMap",
-						Namespace:  "default",
 						Name:       "test-config",
 					},
 					Body: &unstructured.Unstructured{
@@ -296,7 +290,6 @@ metadata:
 					Key: ResourceKey{
 						APIVersion: "v1",
 						Kind:       "Service",
-						Namespace:  "default",
 						Name:       "test-service",
 					},
 					Body: &unstructured.Unstructured{

diff --git a/pkg/app/pipedv1/plugin/kubernetes/provider/resource.go b/pkg/app/pipedv1/plugin/kubernetes/provider/resource.go
@@ -87,9 +87,6 @@ func MakeResourceKey(obj *unstructured.Unstructured) ResourceKey {
 		Namespace:  obj.GetNamespace(),
 		Name:       obj.GetName(),
 	}
-	if k.Namespace == "" {
-		k.Namespace = DefaultNamespace
-	}
 	return k
 }