Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send all remaining events before exiting. #534

Closed
pipecd-bot opened this issue Jul 27, 2020 · 2 comments
Closed

Send all remaining events before exiting. #534

pipecd-bot opened this issue Jul 27, 2020 · 2 comments
Assignees
@nghialv
Labels
area/piped kind/todo

Comments

@pipecd-bot
Copy link
Collaborator

https://github.com/pipe-cd/pipe/blob/c3c85176829e443898d65a62552eda8f8a0b786c/pkg/app/piped/notifier/slack.go#L83-L86

This was created by todo plugin since "TODO:" was found in c3c8517 when #531 was merged. cc: @nghialv.
@nghialv
Copy link
Member

nghialv commented Jul 27, 2020

Resolved by #543
/close

@pipecd-bot
Copy link
Collaborator Author

LIFE_CYCLE

@nghialv: Closed this issue in response to this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nghialv nghialv

Labels
area/piped kind/todo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nghialv @pipecd-bot