Add ability to send notifications to slack #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following files are not gofmt-ed. By commenting pkg/app/piped/notifier/slack.go--- pkg/app/piped/notifier/slack.go.orig
+++ pkg/app/piped/notifier/slack.go
@@ -213,7 +213,7 @@
func makeSlackMessage(title, titleLink, text, color string, timestamp int64, fields ...slackField) slackMessage {
return slackMessage{
Username: slackUsername,
- Attachments: []slackAttachment{slackAttachment{
+ Attachments: []slackAttachment{{
Title: title,
TitleLink: titleLink,
Text: text,
|
pipecd-bot
reviewed
Jul 27, 2020
|
Code coverage for golang is
|
|
Code coverage for golang is
|
nakabonne
reviewed
Jul 27, 2020
pkg/app/piped/notifier/slack.go
Outdated
| md := event.Metadata.(*model.EventDeploymentTriggered) | ||
| title = fmt.Sprintf("Triggered a new deployment for %q", md.Deployment.ApplicationName) | ||
| generateDeploymentEventData(md.Deployment) | ||
| break |
There was a problem hiding this comment.
What are these break statements for?
|
The following ISSUES will be created once got merged. If you want me to skip creating the issue, you can use |
|
Code coverage for golang is
|
nakabonne
reviewed
Jul 27, 2020
| } | ||
| } | ||
|
|
||
| switch event.Type { |
There was a problem hiding this comment.
Just in case, let me confirm that you didn't include intentionally some EventTypes such as EventType_EVENT_APPLICATION_SYNCED etc...
There was a problem hiding this comment.
Yes. Let me add a TODO for them in the next PR.
There was a problem hiding this comment.
Oh, you said adding in the next PR.
|
/approve |
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
This was referenced Jul 27, 2020
|
failed to handle template rule examples Details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:
/cc @nakabonne