Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Canary resource was not deleted correctly #623

Closed
nghialv opened this issue Aug 14, 2020 · 0 comments · Fixed by #719
Closed

Canary resource was not deleted correctly #623

nghialv opened this issue Aug 14, 2020 · 0 comments · Fixed by #719
Assignees
@nghialv
Labels
kind/bug Something isn't working priority/P1 Top priority

Comments

@nghialv
Copy link
Member

nghialv commented Aug 14, 2020

What happened:

Deployment ID: 02e47359-a35b-422f-9434-8c61f0b73401

[2020-08-14 10:41:46 +09:00]
Starting finding and deleting service resources of CANARY variant
[2020-08-14 10:41:46 +09:00]
No resources to delete
[2020-08-14 10:41:46 +09:00]
Starting finding and deleting workload resources of CANARY variant
[2020-08-14 10:41:46 +09:00]
Start deleting 1 resources
[2020-08-14 10:41:46 +09:00]
- no resource apiVersion=apps/v1, kind=Deployment, namespace=default, name=canary-canary to delete
[2020-08-14 10:41:46 +09:00]
Successfully deleted 1 resourc

The following 1 manifests are NOT defined in Git, but appearing in the cluster:
- apiVersion=apps/v1, kind=Deployment, namespace=nghialv-dev, name=canary-canary

What you expected to happen:

How to reproduce it:

Environment:

  • piped version:
  • control-plane version:
  • Others:

/label area/piped
@nghialv nghialv added the kind/bug Something isn't working label Aug 14, 2020
@nghialv nghialv self-assigned this Aug 17, 2020
@nghialv nghialv added the priority/P1 Top priority label Aug 27, 2020
@nghialv nghialv mentioned this issue Aug 27, 2020
Merged
pipecd-bot pushed a commit that referenced this issue Aug 27, 2020
@nghialv
Fix a bug that causes canary resources in a customized namespace were…
c268a99 
… not deleted (#719)

**What this PR does / why we need it**:

**Which issue(s) this PR fixes**:

Fixes #623 

**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
-->
```release-note
NONE
```

This PR was merged by Kapetanios.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nghialv nghialv

Labels
kind/bug Something isn't working priority/P1 Top priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix a bug that causes canary resources in a customized namespace were not deleted pipe-cd/pipecd
1 participant
@nghialv