Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contain git host link within ListDeploymentConfigTemplates response #627

Closed
nakabonne opened this issue Aug 14, 2020 · 0 comments · Fixed by #635
Closed

Contain git host link within ListDeploymentConfigTemplates response #627

nakabonne opened this issue Aug 14, 2020 · 0 comments · Fixed by #635
Assignees
@nakabonne
Labels
kind/enhancement New feature or request priority/P1 Top priority

Comments

@nakabonne
Copy link
Member

What would you like to be added:
Somthing like: https://github.com/{org}/{repo}/new/{branch}/path/to

Why is this needed:
@nakabonne nakabonne added the kind/enhancement New feature or request label Aug 14, 2020
@nakabonne nakabonne self-assigned this Aug 14, 2020
@nakabonne nakabonne added the priority/P1 Top priority label Aug 14, 2020
@nakabonne nakabonne mentioned this issue Aug 17, 2020
Merged
pipecd-bot pushed a commit that referenced this issue Aug 17, 2020
@nakabonne
Ensure to generate file creation URL (#635)
0891c80 
**What this PR does / why we need it**:
Each deployment config template comes with a file creation URL, which is for creating a new file under the git path, with template content as default value. Something like:
https://github.com/pipe-cd/debug/new/master/kubernetes/analysis-by-metrics?filename=.pipe.yaml&value=%23+This+configures+a+non-progressive+delivery.%0AapiVersion%3A+pipecd.dev%2Fv1beta1%0Akind%3A+KubernetesApp%0Aspec%3A%0A++input%3A%0A++++manifests%3A%0A++++++-+deployment.yaml%0A++++++-+service.yaml%0A++++kubectlVersion%3A+2.1.1

Whereas, I'm getting an issue about specifying filename: isaacs/github#1527. I'll be glad to address it later.

**Which issue(s) this PR fixes**:

Fixes #627

**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
-->
```release-note
NONE
```

This PR was merged by Kapetanios.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nakabonne nakabonne

Labels
kind/enhancement New feature or request priority/P1 Top priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure to generate file creation URL pipe-cd/pipecd
1 participant
@nakabonne