Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove this -no-color flag after parsePlanResult supports parsing the message containing color codes. #674

Closed
pipecd-bot opened this issue Aug 21, 2020 · 0 comments · Fixed by #2189
Closed

Remove this -no-color flag after parsePlanResult supports parsing the message containing color codes. #674

pipecd-bot opened this issue Aug 21, 2020 · 0 comments · Fixed by #2189
Labels
area/piped kind/todo

Comments

@pipecd-bot
Copy link
Collaborator

https://github.com/pipe-cd/pipe/blob/e3a8f3156caf93290cb213b8e1de615ad99ad771/pkg/app/piped/cloudprovider/terraform/terraform.go#L109-L112

This was created by todo plugin since "TODO:" was found in e3a8f31 when #671 was merged. cc: @nghialv.
@nghialv nghialv removed their assignment Sep 9, 2020
@nghialv nghialv mentioned this issue Jul 6, 2021
Merged
pipecd-bot pushed a commit that referenced this issue Jul 7, 2021
@nghialv
Make terraform cloud provider able to parse log including ansi codes (#…
9658d3a 
…2189)

**What this PR does / why we need it**:

**Which issue(s) this PR fixes**:

Fixes #674

**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
-->
```release-note
NONE
```

This PR was merged by Kapetanios.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/piped kind/todo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make terraform cloud provider able to parse log including ansi codes pipe-cd/pipecd
2 participants
@nghialv @pipecd-bot