Send error comment before plan preview exit #4658

TakumaKurosawa · 2023-11-08T08:42:19Z

What this PR does / why we need it:
It's hard to know why plan-preview exited.
Sending error comment before exiting makes us easier to find the problem.

Which issue(s) this PR fixes:

Fixes #4657

Does this PR introduce a user-facing change?:

How are users affected by this change:
- plan-preview error comment is going to be added a line break

error comment will displayed before plan-preview exiting
Is this breaking change:
How to migrate (if breaking change):

Signed-off-by: Takumaron <tennis.takumax@gmail.com>

khanhtc1202 · 2023-11-08T11:44:21Z

tool/actions-plan-preview/main.go

@@ -152,7 +154,7 @@ func main() {
 		return
 	}

-	if bool(comment.IsMinimized) {
+	if comment.IsMinimized {


I think this cast is to ensure we can notice if the lib type Boolean changed, so let's keep it.

I see your point👍

@khanhtc1202
Applied!!
5aded83

khanhtc1202 · 2023-11-08T11:45:56Z

Overall looks good, just left a small nit 😄

codecov · 2023-11-08T13:28:23Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (89fb203) 30.81% compared to head (5aded83) 30.83%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4658      +/-   ##
==========================================
+ Coverage   30.81%   30.83%   +0.01%     
==========================================
  Files         221      221              
  Lines       25941    25941              
==========================================
+ Hits         7995     7999       +4     
+ Misses      17296    17292       -4     
  Partials      650      650

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Takumaron <tennis.takumax@gmail.com>

khanhtc1202

Great catch, thank you 🙌

* Send error comment before plan preview exit Signed-off-by: Takumaron <tennis.takumax@gmail.com> * Apply review commnet Signed-off-by: Takumaron <tennis.takumax@gmail.com> --------- Signed-off-by: Takumaron <tennis.takumax@gmail.com>

#4628 #4629 #4631 #4632 #4633 #4637 #4638 #4641 #4648 #4650 #4656 #4658 #4662 #4666 (#4669) * Bump golang.org/x/net from 0.7.0 to 0.17.0 in /tool/actions-plan-preview (#4611) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.7.0 to 0.17.0. - [Commits](golang/net@v0.7.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump golang.org/x/net from 0.7.0 to 0.17.0 in /tool/actions-gh-release (#4612) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.7.0 to 0.17.0. - [Commits](golang/net@v0.7.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com> * Bump golang.org/x/net from 0.8.0 to 0.17.0 (#4613) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.8.0 to 0.17.0. - [Commits](golang/net@v0.8.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @babel/traverse from 7.14.7 to 7.23.2 in /web (#4619) * Fix part of lint/go errors (misspell, depguard, unconvert) (#4621) * Fix lint/go errors (misspell) Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Fix lint/go errors (depguard) Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Fix lint/go errors (unconvert) Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> --------- Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Fix part of lint/go errors (goimports, staticcheck, gosimple) (#4622) * Fix lint/go errors (goimport) Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Fix lint/go errors (staticcheck) Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Fix lint/go errors (gosimple) Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Fix lint/go errors (gosimple) Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Fix return error by function Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> --------- Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Fix part of lint/go errors (deadcode, ineffassign, depguard) (#4624) * Ignore mannwhitney from golangci-lint Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Fix lint/go errors (deadcode) Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Fix lint/go errors (depguard) Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> --------- Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Add tests to terraform platform provider (#4625) Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Add tests to apikey model (#4626) Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Add tests to application model (#4627) Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Reduce `make lint/go` execution time by adding the GOCACHE environment variable (#4628) * Add GOCACHE env to lint/go Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Add verbose flag to lint/go Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Change timeout golangci.yml Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> --------- Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Add tests to model/deployment (#4629) Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Add tests to model/notificationevent (#4631) * Add tests to model/notificationevent Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Add Parallel() Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> --------- Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Add tests to model/deployment_chain (#4632) * Bump google.golang.org/grpc from 1.54.0 to 1.56.3 (#4633) * Bump google.golang.org/grpc from 1.54.0 to 1.56.3 Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.54.0 to 1.56.3. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.54.0...v1.56.3) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * Update grpc test version Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: khanhtc1202 <khanhtc1202@gmail.com> * Fix lint/go errors (gocritic) (#4637) Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Fix part of lint/go errors (stylecheck) (#4638) * Fix lint/go errors (stylecheck) Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Remove nolint:stylecheck Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Change method reveiver name Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Change receiver name k to ak Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> --------- Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Bump github.com/docker/docker (#4641) * Make actions plan preview handle timeout option (#4648) * Format and make tests pass in tool/actions-plan-preview Signed-off-by: mi11km <mi11km.program@gmail.com> * Use --piped-handle-timeout to make the timeout arg activate Signed-off-by: mi11km <mi11km.program@gmail.com> * Add tests to model/notificationevent (#4631) * Add tests to model/notificationevent Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Add Parallel() Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> --------- Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> Signed-off-by: mi11km <mi11km.program@gmail.com> * add piped-handle-timeout(input args) Signed-off-by: mi11km <mi11km.program@gmail.com> --------- Signed-off-by: mi11km <mi11km.program@gmail.com> Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> Co-authored-by: Kenta Kozuka <kenta.kozuka@gmail.com> Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com> * Fix panic error in ListDeployments API (#4650) * Update golangci-lint and fix lint errors (#4656) Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> * Send error comment before plan preview exit (#4658) * Send error comment before plan preview exit Signed-off-by: Takumaron <tennis.takumax@gmail.com> * Apply review commnet Signed-off-by: Takumaron <tennis.takumax@gmail.com> --------- Signed-off-by: Takumaron <tennis.takumax@gmail.com> * Handle plan preview workflow's error and exit with error status code (#4662) * Add a flag to skip running standalone task during deployment (#4666) * Add a flag to skip running standalone task during deployment Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> * Fix docs Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> --------- Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: karamaru-alpha <mrnk3078@gmail.com> Signed-off-by: Kenta Kozuka <kenta.kozuka@gmail.com> Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Signed-off-by: mi11km <mi11km.program@gmail.com> Signed-off-by: Takumaron <tennis.takumax@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com> Co-authored-by: karamaru <38310693+karamaru-alpha@users.noreply.github.com> Co-authored-by: Kenta Kozuka <kenta.kozuka@gmail.com> Co-authored-by: khanhtc1202 <khanhtc1202@gmail.com> Co-authored-by: Masafumi Ikeyama <54844746+mi11km@users.noreply.github.com> Co-authored-by: Seitaro Fujigaki <51070449+seitarof@users.noreply.github.com> Co-authored-by: Kurosawa Takuma <tennis.takumax@gmail.com>

* Send error comment before plan preview exit Signed-off-by: Takumaron <tennis.takumax@gmail.com> * Apply review commnet Signed-off-by: Takumaron <tennis.takumax@gmail.com> --------- Signed-off-by: Takumaron <tennis.takumax@gmail.com>

* Send error comment before plan preview exit Signed-off-by: Takumaron <tennis.takumax@gmail.com> * Apply review commnet Signed-off-by: Takumaron <tennis.takumax@gmail.com> --------- Signed-off-by: Takumaron <tennis.takumax@gmail.com> Signed-off-by: 鈴木優耀 <suzuki_masaaki@cyberagent.co.jp>

TakumaKurosawa requested review from nghialv, khanhtc1202, kentakozuka and ffjlabo as code owners November 8, 2023 08:42

github-actions bot added the area/tool label Nov 8, 2023

Send error comment before plan preview exit

78f339e

Signed-off-by: Takumaron <tennis.takumax@gmail.com>

TakumaKurosawa force-pushed the comment-before-os-exit branch from a438f11 to 78f339e Compare November 8, 2023 08:49

TakumaKurosawa mentioned this pull request Nov 8, 2023

Send error comment before plan preview exit #4657

Closed

khanhtc1202 reviewed Nov 8, 2023

View reviewed changes

TakumaKurosawa requested a review from khanhtc1202 November 9, 2023 02:02

Apply review commnet

5aded83

Signed-off-by: Takumaron <tennis.takumax@gmail.com>

TakumaKurosawa force-pushed the comment-before-os-exit branch from 449aa1b to 5aded83 Compare November 9, 2023 02:03

khanhtc1202 enabled auto-merge (squash) November 9, 2023 12:30

khanhtc1202 approved these changes Nov 9, 2023

View reviewed changes

khanhtc1202 merged commit 88d7fb6 into pipe-cd:master Nov 9, 2023

TakumaKurosawa deleted the comment-before-os-exit branch November 10, 2023 00:50

ffjlabo mentioned this pull request Nov 13, 2023

Cherry-pick #4611 #4612 #4613 #4619 #4621 #4622 #4624 #4625 #4626 #4627 #4628 #4629 #4631 #4632 #4633 #4637 #4638 #4641 #4648 #4650 #4656 #4658 #4662 #4666 #4669

Merged

github-actions bot mentioned this pull request Dec 1, 2023

Release v0.45.4 #4697

Merged

github-actions bot mentioned this pull request Feb 6, 2024

Release v0.46.0 #4775

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Send error comment before plan preview exit #4658

Send error comment before plan preview exit #4658

TakumaKurosawa commented Nov 8, 2023 •

edited

Loading

khanhtc1202 Nov 8, 2023

TakumaKurosawa Nov 9, 2023

TakumaKurosawa Nov 9, 2023 •

edited

Loading

khanhtc1202 commented Nov 8, 2023

codecov bot commented Nov 8, 2023 •

edited

Loading

khanhtc1202 left a comment

Send error comment before plan preview exit #4658

Send error comment before plan preview exit #4658

Conversation

TakumaKurosawa commented Nov 8, 2023 • edited Loading

khanhtc1202 Nov 8, 2023

Choose a reason for hiding this comment

TakumaKurosawa Nov 9, 2023

Choose a reason for hiding this comment

TakumaKurosawa Nov 9, 2023 • edited Loading

Choose a reason for hiding this comment

khanhtc1202 commented Nov 8, 2023

codecov bot commented Nov 8, 2023 • edited Loading

Codecov Report

khanhtc1202 left a comment

Choose a reason for hiding this comment

TakumaKurosawa commented Nov 8, 2023 •

edited

Loading

TakumaKurosawa Nov 9, 2023 •

edited

Loading

codecov bot commented Nov 8, 2023 •

edited

Loading