Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ECS): enable selection of listener rules #4668
feat(ECS): enable selection of listener rules #4668
Changes from 12 commits
9e78352
41b67d6
78de40b
5ea306a
5b3ac3f
e7cb581
a25602c
965ba41
3a4bea5
0b01246
abd12ca
38855ce
2650922
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will delete all other rules of a given listener in case that listener contains rules of type
ActionTypeEnumForward
? 🤔 So this code change means nothing, I guess. wdyt? @moko-poiThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@khanhtc1202
2650922
Thank you for your review.
I have made the necessary adjustments to the ModifyListeners and ModifyRules functions to address the concerns. Now, these functions only modify actions of type ActionTypeEnumForward and preserve all other action types, ensuring that existing listener and rule configurations are not inadvertently altered.