Add PipelineStage.Rollback and mark PipelineStage.Visible as deprecated #5232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
khanhtc1202
requested review from
nghialv,
kentakozuka,
ffjlabo,
t-kikuc and
Warashi
as code owners
Warashi
previously approved these changes
Sep 26, 2024
t-kikuc
changed the title
t-kikuc
previously approved these changes
Sep 26, 2024
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5232 +/- ##
==========================================
+ Coverage 22.92% 22.93% +0.01%
==========================================
Files 419 419
Lines 45323 45325 +2
==========================================
+ Hits 10389 10395 +6
+ Misses 34136 34133 -3
+ Partials 798 797 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
t-kikuc
approved these changes
Sep 27, 2024
This was referenced Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Part of #4980
Related to #5230
Does this PR introduce a user-facing change?: