Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image uri for cloud run install #5281

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Conversation

ffjlabo
Copy link
Member

@ffjlabo ffjlabo commented Oct 16, 2024

What this PR does:

as title.

Currently, Cloud Run can't use the container image hosted on the ghcr.io directly.
https://cloud.google.com/run/docs/deploying#images

Why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.31%. Comparing base (7da4bd5) to head (c24b7e6).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5281      +/-   ##
==========================================
- Coverage   24.31%   24.31%   -0.01%     
==========================================
  Files         440      440              
  Lines       46784    46784              
==========================================
- Hits        11376    11374       -2     
- Misses      34504    34507       +3     
+ Partials      904      903       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@khanhtc1202 khanhtc1202 merged commit 039f9d3 into master Oct 16, 2024
18 checks passed
@khanhtc1202 khanhtc1202 deleted the fix-image-uri-for-cloud-run branch October 16, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants