Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Helm chart handling in Loader with support for local charts #5350

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

Warashi
Copy link
Contributor

@Warashi Warashi commented Nov 20, 2024

What this PR does:

This PR implements helm chart handling with support for local charts.
The templating remote repository has not been implemented yet.

Why we need it:

We have to support helm charts in the kubernetes plugin

Which issue(s) this PR fixes:

Part of #4980

Does this PR introduce a user-facing change?: No

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 55.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 25.38%. Comparing base (7ee065a) to head (3cc769e).
Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
...g/app/pipedv1/plugin/kubernetes/provider/loader.go 55.00% 8 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5350      +/-   ##
==========================================
+ Coverage   25.36%   25.38%   +0.02%     
==========================================
  Files         445      445              
  Lines       47772    47790      +18     
==========================================
+ Hits        12116    12132      +16     
+ Misses      34705    34703       -2     
- Partials      951      955       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@Warashi Warashi merged commit 44dd631 into master Nov 26, 2024
18 checks passed
@Warashi Warashi deleted the k8s-plugin-load-local-helm-chart branch November 26, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants