Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify rfc for deprecating Kind and Platform Provider #5365

Merged

Conversation

ffjlabo
Copy link
Member

@ffjlabo ffjlabo commented Nov 25, 2024

What this PR does:

Modified the way to deprecate Kind and Platform Provider in the RFC for plugin architecture.

Why we need it:

We don't use the Kind and Platform Provider because we migrate the DB data before updating pipedv1.
After updated, the pipedv1 refers labels["kind"] and daployTarget instead of Kind and Platform Provider.

Which issue(s) this PR fixes:

Part of #5252
Related to #5358

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.44%. Comparing base (ab687f3) to head (5262dc4).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5365   +/-   ##
=======================================
  Coverage   25.44%   25.44%           
=======================================
  Files         446      446           
  Lines       47844    47844           
=======================================
  Hits        12172    12172           
  Misses      34720    34720           
  Partials      952      952           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got your point. LGTM.

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@ffjlabo ffjlabo merged commit 90b5d07 into master Nov 26, 2024
18 checks passed
@ffjlabo ffjlabo deleted the modify-docs-for-deprecating-kind-and-platform-provider branch November 26, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants