Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Kubectl command wrapper with apply, create, replace, and delete functionalities #5380

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

Warashi
Copy link
Contributor

@Warashi Warashi commented Dec 3, 2024

What this PR does:

This PR implements the kubectl wrapper for the k8s plugin.

Why we need it:

We need this to apply k8s manifests.

Which issue(s) this PR fixes:

Part of #4980

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

…lete functionalities

Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 186 lines in your changes missing coverage. Please review.

Project coverage is 25.68%. Comparing base (04c1f35) to head (0b66a3a).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
.../app/pipedv1/plugin/kubernetes/provider/kubectl.go 0.00% 184 Missing ⚠️
...app/pipedv1/plugin/kubernetes/provider/manifest.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5380      +/-   ##
==========================================
- Coverage   25.76%   25.68%   -0.09%     
==========================================
  Files         445      446       +1     
  Lines       47947    48133     +186     
==========================================
+ Hits        12355    12361       +6     
- Misses      34630    34810     +180     
  Partials      962      962              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Warashi Warashi merged commit 6e10e02 into master Dec 3, 2024
16 of 18 checks passed
@Warashi Warashi deleted the k8s-plugin-kubectl-wrapper branch December 3, 2024 02:00
@github-actions github-actions bot mentioned this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants