Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the piped to correct invoking the k8s plugin #5401

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

Warashi
Copy link
Contributor

@Warashi Warashi commented Dec 10, 2024

What this PR does:

as title

Why we need it:

Without this PR, the pipedv1 cannot invoke the k8s plugin.

Which issue(s) this PR fixes:

Part of #4980

Does this PR introduce a user-facing change?: No

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
@t-kikuc t-kikuc enabled auto-merge (squash) December 10, 2024 03:13
@t-kikuc t-kikuc merged commit 74de8a0 into master Dec 10, 2024
16 checks passed
@t-kikuc t-kikuc deleted the k8s-plugin-fix-create-piped-client branch December 10, 2024 03:17
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 25.71%. Comparing base (4f1ff0f) to head (f51480a).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/pipedv1/cmd/piped/piped.go 0.00% 1 Missing ⚠️
pkg/app/pipedv1/plugin/kubernetes/server.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5401      +/-   ##
==========================================
- Coverage   25.73%   25.71%   -0.03%     
==========================================
  Files         449      449              
  Lines       48452    48452              
==========================================
- Hits        12470    12460      -10     
- Misses      35008    35020      +12     
+ Partials      974      972       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot mentioned this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants