Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement preparing the deploy source in pipedv1 planner / scheduler #5410

Merged
merged 11 commits into from
Dec 13, 2024

Conversation

Warashi
Copy link
Contributor

@Warashi Warashi commented Dec 11, 2024

What this PR does:

  • as title
  • fix the bug of ToolRegistry in pipedv1
  • fix the bug of k8s plugin, the log persister is not running

Why we need it:

without this PR, we cannot plan/execute the deployment

Which issue(s) this PR fixes:

Part of #4980

Does this PR introduce a user-facing change?: No

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 14.42308% with 89 lines in your changes missing coverage. Please review.

Project coverage is 25.95%. Comparing base (702b984) to head (2d0af05).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/pipedv1/controller/scheduler.go 10.52% 32 Missing and 2 partials ⚠️
pkg/app/pipedv1/controller/planner.go 0.00% 29 Missing ⚠️
pkg/app/pipedv1/deploysource/deploysource.go 28.00% 18 Missing ⚠️
pkg/app/pipedv1/plugin/kubernetes/server.go 0.00% 5 Missing ⚠️
pkg/app/pipedv1/cmd/piped/grpcapi/tool_registry.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5410      +/-   ##
==========================================
- Coverage   25.95%   25.95%   -0.01%     
==========================================
  Files         451      451              
  Lines       48731    48793      +62     
==========================================
+ Hits        12649    12663      +14     
- Misses      35081    35124      +43     
- Partials     1001     1006       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Warashi and others added 6 commits December 11, 2024 13:30
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
…rface

Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
@khanhtc1202 khanhtc1202 marked this pull request as ready for review December 13, 2024 09:43
khanhtc1202
khanhtc1202 previously approved these changes Dec 13, 2024
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@ffjlabo ffjlabo enabled auto-merge (squash) December 13, 2024 09:56
@ffjlabo ffjlabo merged commit d5ba3d2 into master Dec 13, 2024
14 of 18 checks passed
@ffjlabo ffjlabo deleted the pipedv1-prepare-deploy-source branch December 13, 2024 09:58
@github-actions github-actions bot mentioned this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants