-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry-pick #5412 #5419
Cherry-pick #5412 #5419
Conversation
* Use git worktree and partial clone to reduce network io Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> * Add defer statement to clean up cloned git repositories in detector implementations Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> * Change the repo.Copy to use worktree and implement CopyToModify Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> * Add tests for Copy and CopyToModify methods in repo Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> * repo.Copy and related methods updated to use git.Worktree instead of git.Repo Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> * MockRepo.Copy method updated to return git.Worktree instead of git.Repo Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> * Update CopyToModify method to clone repository using git clone command Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> * Test: Update TestCopy to use repo.Copy instead of CopyToModify Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> * Fix comment in CopyToModify to clarify remote URL setting after local cloning Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> * Fetch the latest changes from remote after local cloning Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> * Remove .git directory from copied deploy source to avoid the git ops Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> * Update TestCopyToModify to use a mock remote directory for testing Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> * Copy deploy source using tar to exclude .git directory and improve performance Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> --------- Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>
closeed and reopened to run workflows |
cherry-pick targets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's go 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-v0.50.x #5419 +/- ##
===================================================
- Coverage 25.77% 25.75% -0.02%
===================================================
Files 445 445
Lines 47947 48033 +86
===================================================
+ Hits 12357 12370 +13
- Misses 34627 34696 +69
- Partials 963 967 +4 ☔ View full report in Codecov by Sentry. |
What this PR does / why we need it:
Cherry pick of #5412.