Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround for aarch64 container image build #5423

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

Warashi
Copy link
Contributor

@Warashi Warashi commented Dec 16, 2024

What this PR does:

Add workaround for building pipecd arm64 image.

Why we need it:

to make the publish_image_chart workflow success

Which issue(s) this PR fixes:

Fix #5422

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
@Warashi
Copy link
Contributor Author

Warashi commented Dec 16, 2024

The workflow may become a success with one of these workarounds, but I think it's robust to add both of them.

@Warashi Warashi marked this pull request as ready for review December 16, 2024 05:12
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.96%. Comparing base (e83e9d0) to head (f48959c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5423   +/-   ##
=======================================
  Coverage   25.95%   25.96%           
=======================================
  Files         451      451           
  Lines       48793    48793           
=======================================
+ Hits        12665    12669    +4     
+ Misses      35121    35118    -3     
+ Partials     1007     1006    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Warashi Warashi merged commit 5e1a7f5 into master Dec 16, 2024
16 of 18 checks passed
@Warashi Warashi deleted the control-plane-aarch64-build branch December 16, 2024 05:19
@github-actions github-actions bot mentioned this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The workflow publish_image_chart fails
3 participants