Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass secret decrypter to pipedv1 schedulers and planners #5433

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

khanhtc1202
Copy link
Member

@khanhtc1202 khanhtc1202 commented Dec 17, 2024

What this PR does:

Pass the secret decrypter to Pipedv1 schedulers and planners to use piped built-in secret management feature.

Also, minor fixes on

  • logger pass more info

Why we need it:

Which issue(s) this PR fixes:

Part of #4980

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 2.22222% with 44 lines in your changes missing coverage. Please review.

Project coverage is 26.09%. Comparing base (40f8375) to head (3979665).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/pipedv1/controller/planner.go 0.00% 19 Missing ⚠️
pkg/app/pipedv1/controller/scheduler.go 5.88% 16 Missing ⚠️
pkg/app/pipedv1/cmd/piped/piped.go 0.00% 6 Missing ⚠️
pkg/app/pipedv1/controller/controller.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5433      +/-   ##
==========================================
- Coverage   26.10%   26.09%   -0.01%     
==========================================
  Files         451      451              
  Lines       48824    48838      +14     
==========================================
- Hits        12747    12746       -1     
- Misses      35059    35074      +15     
  Partials     1018     1018              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Copy link
Contributor

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@khanhtc1202 khanhtc1202 merged commit 17a5007 into master Dec 18, 2024
16 of 18 checks passed
@khanhtc1202 khanhtc1202 deleted the update-planner-scheduler branch December 18, 2024 06:05
@github-actions github-actions bot mentioned this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants