Fixed to certainly store the metadata in graceful shutdown #5461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
t-kikuc
requested review from
nghialv,
khanhtc1202,
kentakozuka,
ffjlabo and
Warashi
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5461 +/- ##
==========================================
- Coverage 26.14% 26.14% -0.01%
==========================================
Files 457 457
Lines 49107 49107
==========================================
- Hits 12841 12837 -4
- Misses 35244 35247 +3
- Partials 1022 1023 +1 ☔ View full report in Codecov by Sentry. |
ffjlabo
approved these changes
Dec 27, 2024
Merged
github-actions bot
pushed a commit
that referenced
this pull request
Jan 21, 2025
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>
Warashi
added a commit
that referenced
this pull request
Jan 21, 2025
* [ECS] Support 5 missing fields in TaskDefinition (#5424) * Add missing fields in RegisterTaskDef Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * remove two restrictions Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> --------- Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> * [ECS] Enabled to configure/update `PropagateTags` and `EnableECSManagedTags` (#5425) * Enable updating PropagateTags and specifying other than SERVICE Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Enable updating EnableECSManagedTags Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Remove default PropagateTags: unnecessary Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * support propagateTags other than SERVICE Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> --------- Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> * Enhance logging in EventWatcher (#5443) * Add logger.Error() before returning for detailed logs Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Enhance error logging in event watcher with additional context for push and commit failures Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> --------- Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> * fixed to certainly store the startTime (#5461) Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> * Add default envs in ScriptRunStage: SR_TRIGGERED_COMMANDER, SR_IS_ROLLBACK (#5464) * Add TriggeredCommandar Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * add isRollback Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * update docs Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * fix name->id Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * fix env name Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * fix: specify isRollback since deployment.Status is always Planned Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * fix typo Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> * Add case of `pipectl sync` Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> --------- Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> * Release v0.50.1 (#5498) Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> --------- Signed-off-by: t-kikuc <tkikuchi07f@gmail.com> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> Co-authored-by: Tetsuya KIKUCHI <97105818+t-kikuc@users.noreply.github.com> Co-authored-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
as title.
Why we need it:
Currently, the Wait stage waits for the whole duration AGAIN after graceful shutdown.
That's because graceful shutdown cannot store
startTimeto Control Plane.Before fix (wait 1m again after restarting):
After fix (wait ends soon after restarting):
Which issue(s) this PR fixes:
Does this PR introduce a user-facing change?: