Add service configuration page #17
Merged
+1,133
−229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Regaddi
force-pushed
the
cst/service-config-page
branch
from
dd4499b
to
c4f2dc7
Compare
Regaddi
commented
Nov 19, 2024
| @@ -128,7 +128,7 @@ async def update_service( | |||
| result = await db.execute(select(Service).where(Service.service_id == service_id)) | |||
| service = result.scalar_one_or_none() | |||
|
|
|||
| return ServiceModel.model_validate(service) | |||
There was a problem hiding this comment.
This was constantly throwing an error after successfully updating a service.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short summary of changes (please include issue #)
This adds a service configuration page and removes the API Keys section from the workspace configuration form.
With this services can be added, edited and removed.
I also added missing LLM models and voice options.
The current validation rules in the API only allow a provider to be added once per user, but I think it should be once per user + service_type + workspace_id. Currently it's not possible to add OpenAI as an LLM provider and as a TTS provider.I updated the constraints, but I think it needs a migration, too.Screenshots