forked from kubernetes/kubernetes
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
kubeadm: Idempotent service account creation.
Ignore errors for duplicates when creating service accounts. kubernetes/kubeadm#278
- Loading branch information
Showing
3 changed files
with
98 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| /* | ||
| Copyright 2017 The Kubernetes Authors. | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package apiconfig | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| apierrors "k8s.io/apimachinery/pkg/api/errors" | ||
| "k8s.io/apimachinery/pkg/runtime" | ||
| clientsetfake "k8s.io/client-go/kubernetes/fake" | ||
| core "k8s.io/client-go/testing" | ||
| "k8s.io/kubernetes/pkg/api" | ||
| ) | ||
|
|
||
| func TestCreateServiceAccounts(t *testing.T) { | ||
| tests := []struct { | ||
| name string | ||
| createErr error | ||
| expectErr bool | ||
| }{ | ||
| { | ||
| "error-free case", | ||
| nil, | ||
| false, | ||
| }, | ||
| { | ||
| "duplication errors should be ignored", | ||
| apierrors.NewAlreadyExists(api.Resource(""), ""), | ||
| false, | ||
| }, | ||
| { | ||
| "unexpected errors should be returned", | ||
| apierrors.NewUnauthorized(""), | ||
| true, | ||
| }, | ||
| } | ||
|
|
||
| for _, tc := range tests { | ||
| client := clientsetfake.NewSimpleClientset() | ||
| if tc.createErr != nil { | ||
| client.PrependReactor("create", "serviceaccounts", func(action core.Action) (bool, runtime.Object, error) { | ||
| return true, nil, tc.createErr | ||
| }) | ||
| } | ||
|
|
||
| err := CreateServiceAccounts(client) | ||
| if tc.expectErr { | ||
| if err == nil { | ||
| t.Errorf("CreateServiceAccounts(%s) wanted err, got nil", tc.name) | ||
| } | ||
| continue | ||
| } else if !tc.expectErr && err != nil { | ||
| t.Errorf("CreateServiceAccounts(%s) returned unexpected err: %v", tc.name, err) | ||
| } | ||
|
|
||
| wantResourcesCreated := 2 | ||
| if len(client.Actions()) != wantResourcesCreated { | ||
| t.Errorf("CreateServiceAccounts(%s) should have made %d actions, but made %d", tc.name, wantResourcesCreated, len(client.Actions())) | ||
| } | ||
|
|
||
| for _, action := range client.Actions() { | ||
| if action.GetVerb() != "create" || action.GetResource().Resource != "serviceaccounts" { | ||
| t.Errorf("CreateServiceAccounts(%s) called [%v %v], but wanted [create serviceaccounts]", | ||
| tc.name, action.GetVerb(), action.GetResource().Resource) | ||
| } | ||
| } | ||
|
|
||
| } | ||
| } |