refactor: remove unnecessary and redundant declarations, that don't m…

[diogomene]

What was done?

Unnecessary local variables were removed from the codebase to improve readability and maintainability. The removed variables did not enhance the comprehensibility of the function and introduced redundant code. For instance, in the following example:

matrix.transformVec2(pointB, xfB, localPointB);

matrix.subVec2(this.m_axis, pointB, pointA);

const s = matrix.normalizeVec2Length(this.m_axis);

return s;

(collision/TimeOfImpact.ts)

The local variable s added no meaningful context to the function’s behavior. By directly returning the result of matrix.normalizeVec2Length(this.m_axis);, the code becomes cleaner and easier to follow without altering its functionality.

This may help the code remain concise and focused while adhering to best practices for code simplicity. Each change was reviewed and tested to confirm no impact on the functionality or correctness of the program.

Evidences?

The following SARIF file (generated by Qodana) contains the analysis information of the code smells analysed before the code changes.
qodana.sarif(1).json

Most of the occurrences were identified as potentially helpful syntactic sugar declarations (16 out of the 26 occurrences), ant therefore were not changed, at all.

[vercel]

@diogomene is attempting to deploy a commit to the Piqnt Team on Vercel.

A member of the Team first needs to authorize it.