remove losetup dependency for ROX support #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In d2f23d6 we introduced ROX volume support, which works around DRBD's autopromote feature by introducing a readonly loop-device so all access is done readonly. The code to handle detaching needed to clean up the loop device, which relied on a specifc implementation of "losetup --list", which is not compatible with older version (such as the one found in CentOS 7). This meant that _all_ PVC failed to detach. This commit switches to using "blockdev --setro" to ensure readonly access. That in turn requires DRBD v9.0.26, which is not released yet. This should not be a problem, as the feature was probably never used anyways.
|
@rck I guess you were right about this feature :/ |
|
LGTM. Thanks for fixing it |
|
I just noticed that RWX volumes has loop device set as well, is it bug or feature? I'm using tag |
|
That has nothing to do with LINSTOR CSI (we don't use |
|
Got it! Thanks |
|
After some digging, I found that loop devices are used by Kubernetes for some locking mechanism to not let volume device be silently detached. more details here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In d2f23d6 we introduced ROX volume support, which works around DRBD's
autopromote feature by introducing a readonly loop-device so all access
is done readonly.
The code to handle detaching needed to clean up the loop device, which
relied on a specifc implementation of "losetup --list", which is not
compatible with older version (such as the one found in CentOS 7).
This meant that all PVC failed to detach.
This commit switches to using "blockdev --setro" to ensure readonly access.
That in turn requires DRBD v9.0.26, which is not released yet. This should
not be a problem, as the feature was probably never used anyways.