Commits on Dec 2, 2020

1. Fix a idempotency issues in CreateVolume …

   In case creating a new volume takes longer than the GRPC timeout,
   the provisioner could get in a state where volumes are considered
   ready even if no resource was ever created. This commit fixes this
   issue by ensuring that volumes are only considered ready after the
   expected amount of volumes was placed.
   
   The bug happened in cases where:
   * Create() succesfully called saveVolume(), persisting the volume
     information as annotations, which is interpreted as "ready" resources
   * Immediatly after, the GRPC timeout cancels the request context, meaning
     the volume scheduler aborted before any resources could be assigned to
     nodes
   
   A simple reording of "volumeScheduler.Create()" and "saveVolume()" would
   lead to a different issue, in which continuously more volumes are placed
   but never marked as ready. To prevent this, volumes that reference at least
   the number of resources as required by the parameters are considered ready.
   
   Note that this is a stopgap solution until volume schedulers are re-written
   to be idempotent themselves.

   

   WanzenBug committed Dec 2, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for f4eeb37
   • Browse repository at this point

   Copy the full SHA

   f4eeb37 View commit details

   Browse the repository at this point in the history