Skip to content

Commit

Permalink
Update docs and comment for disbaling node tainting
Browse files Browse the repository at this point in the history
Signed-off-by: Jeremy Scott <js185692@ncr.com>
  • Loading branch information
js185692 committed Dec 17, 2024
1 parent 3fff942 commit e39ebff
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ The Piraeus High Availability Controller itself can be configured using the foll
--request-timeout string The length of time to wait before giving up on a single server request. Non-zero values should contain a corresponding time unit (e.g. 1s, 2m, 3h). A value of zero means don't timeout requests. (default "0")
--resync-interval duration how often the internal object cache should be resynchronized (default 5m0s)
--v int32 set log level (default 0)
--disable-node-taints boolean when set to true; node taints will not be applied (default false)
```

You can directly set them through the helm chart using the matching `options` value.
Expand Down
2 changes: 1 addition & 1 deletion pkg/agent/agent.go
Original file line number Diff line number Diff line change
Expand Up @@ -568,7 +568,7 @@ func hasPersistentVolumeClaimRef(pv *corev1.PersistentVolume) bool {

// TaintNode adds the specific taint to the node.
//
// Returns false, nil if the taint was already present.
// Returns false, nil if the taint was already present or applying node taints had been disabled.
func TaintNode(ctx context.Context, client kubernetes.Interface, node *corev1.Node, taint corev1.Taint, disableNodeTaints bool) (bool, error) {
if disableNodeTaints || node == nil {
return false, nil
Expand Down

0 comments on commit e39ebff

Please sign in to comment.