Skip to content

protocol: avoid double buffering #34

protocol: avoid double buffering

protocol: avoid double buffering #34

Re-run triggered September 17, 2024 16:57
Status Failure
Total duration 2m 48s
Artifacts

golangci-lint.yml

on: pull_request
Matrix: lint
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 1 warning
lint (1.20): protocol.go#L343
Error return value of `p.bufReader.Read` is not checked (errcheck)
lint (1.20): protocol.go#L344
Error return value of `p.bufReader.Discard` is not checked (errcheck)
lint (1.20): v2_test.go#L54
SA1019: rand.Read has been deprecated since Go 1.20 because it shouldn't be used: For almost all use cases, crypto/rand.Read is more appropriate. (staticcheck)
lint (1.20): protocol_test.go#L14
SA1019: "io/ioutil" has been deprecated since Go 1.19: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details. (staticcheck)
lint (1.20)
issues found
lint (1.19)
The job was canceled because "_1_20" failed.
lint (1.19): protocol.go#L343
Error return value of `p.bufReader.Read` is not checked (errcheck)
lint (1.19): protocol.go#L344
Error return value of `p.bufReader.Discard` is not checked (errcheck)
lint (1.19): protocol_test.go#L14
SA1019: "io/ioutil" has been deprecated since Go 1.19: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details. (staticcheck)
lint (1.19)
issues found
lint (1.20)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-go@v3, actions/checkout@v3, golangci/golangci-lint-action@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/