adding configmaps

[puja108]

solving #58

WIP

[puja108]

WFM on minikube 0.15.0 (k8s 1.5.1)

I'll add some docs changes

[puja108]

RFR @pires

[pires]

@puja108 TBH this is more verbose with little gains. I was thinking more of having a ConfigMap containing default elasticsearch.yml (that already consumes environment variables) and simply override the ones specific to each deployment. WDYT?

[puja108]

True, somehow didn't think of the elasticsearch.yml before. What do you mean by override? With envs again?

[pires]

- name: ES_JAVA_OPTS
  valueFrom:
    configMapKeyRef:
      name: es-config
      key: ES_JAVA_OPTS

Here you're still using container environment variables to override values in elasticsearch.yml, right? The idea would be to remove almost all options but the ones specific to each deployment, e.g. NODE_MASTER=false.

[puja108]

Sure, the general options are only 2 though (cluster name and java opts). So I'd move those two into elasticsearch.yml. Might be that we could set some more, but not sure how ES overrides, do envs override the yaml?

[pires]

If the yaml refers to environment variables, yes, e.g. https://github.com/pires/docker-elasticsearch/blob/master/config/elasticsearch.yml.

[puja108]

Yeah, still the envs need to be set, I meant more like overriding the yaml with an env. cause otherwise the yaml would be nearly identical to what you posted (minus the 2 general options). If overriding would be possible we could set a "default" in the yaml and override it only when needed. E.g. default is HTTP_ENABLED=false but for client we enable it.

There's something about a es.default. prefix, but that seems to be the other way around, e.g. being set only if it's not already in the yaml.

[pires]

@puja108 thanks for taking the effort to get this going, truly appreciated. I need to take some time to focus on this. Will ping you ASAP!

[Dexyon]

@puja108 Aren't you missing the including of the ConfigMap in the Deployment file?

[korczis]

@puja108 Any further plans with this?

[pires]

Actually, the fact this isn't merged is my fault. I still haven't found the time to test properly and merge. So sorry all, but most of all @puja108 😭

[korczis]

Once this get merged will be possible to use it for x-pack credentials rotation?

[alexbrand]

@pires @puja108 I might be able to take a stab at this if you are busy with other work.

[pires]

@alexbrand that would be sweet!

[karlskewes]

@alexbrand @pires
Hey guys, have you had any time to progress this?
The original pull request with subsequent conversation about overriding configmap with env vars for client/data/master role variances looks good...?

[alexbrand]

@kskewes Unfortunately no.