-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is this still active #29
Comments
Yup. Absolutely active. Acme is just an example. The test is meant to fail, since you actually need to specify the proper selector in Name of the resort should be lowercase (timberline), the URL should be the page that actually have the list status ( https://www.timberlinelodge.com/conditions ? ) The coordinates should be in latitude/longitude order (think x,y). Open the PR with what you have already and I'll have a look. |
I am closing issue. Currently can't get it to work with timberline/ perhaps it doesn't scrape the page correctly, but I will try with a couple other resorts to see if it's just and error from me.
|
I added the Timberline Lodge resort and I tried to leave some breadcrumbs in the git history to clarify what needs to happen for the new resort to be added:
this is what you get after running
here you add expected list of ski lifts to the test - now the test is still failing but you see what you are aiming for
most important one - this actually implements ski lift status parser - it adds CSS expressions that find the relevant info in the HTML - it's a creative part 😄
extra credit - US resorts can have more precise weather forecast if there is a NOAA station nearby - all it takes to find and add it is
another extra credit 🏅 - normally just specifying position would add some webcams to the liftie page but you can also just add links to the webcams in Please note: for some reason - probably the demise of the webcam.trave API this does not work at the moment. I'll see what I can do to fix it. |
It's hard to tell given lifts are shut down, but the links provided are no longer active:
http://acme.com/lift/status
That leads to a dead end. I am assuming the api used just isn't active anymore, but maybe I am doing something wrong
Not sure how I would add resorts if I don't know the accurate names:
I tried by just making my own:
This doesn't pass tests:
The text was updated successfully, but these errors were encountered: