Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update page titles / positions in docs #727

Merged

Conversation

tsekiguchi
Copy link
Contributor

I went back to check to see if I could find the page on electron that I had submitted in the docs, but realized that I accidentally hadn't changed the id at the top of the page. Also saw that the sidebar positions were also out of order, so I updated them to all be alphabetical.

Lastly, Typescript setup usually is found in the installation category, so I moved it up there. There was a duplicate 'typescript.md' file in examples, so I removed that as well.

Copy link
Member

@metcoder95 metcoder95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Can you fix the conflicts?

@metcoder95 metcoder95 merged commit 9fbb988 into piscinajs:current Jan 9, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants