Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build related issues #1047

Closed
5 tasks done
ayushmanchhabra opened this issue Jan 30, 2022 · 2 comments
Closed
5 tasks done

Fix build related issues #1047

ayushmanchhabra opened this issue Jan 30, 2022 · 2 comments

Comments

@ayushmanchhabra
Copy link

ayushmanchhabra commented Jan 30, 2022

I'll use this issue to track changes made to #1049 to fix build process related errors.

  • Allow installation of node_modules on Node 14
  • Fix test configuration
  • Fix desktop builds
  • Update dependencies
  • Figure out way to reliably host desktop binaries

p.s.: @juliandescottes and @bcharbonnier, I sent you guys an email from ayushmxn@outlook.com. There is a chance it could have gone into your spam so just wanted to give you a heads up here. Anyways, hopefully chat soon.

@ayushmanchhabra ayushmanchhabra changed the title Not an issue Not an issue, but a question Feb 11, 2022
@ayushmanchhabra ayushmanchhabra changed the title Not an issue, but a question Fix build process related issues Feb 11, 2022
@ayushmanchhabra ayushmanchhabra changed the title Fix build process related issues Fix build related issues Feb 11, 2022
@ayushmanchhabra
Copy link
Author

ayushmanchhabra commented Feb 11, 2022

While trying to build the desktop application, this error shows up. I'm not yet sure if this is the cause though.

>> TypeError: os.tmpDir is not a function
Warning: Task "nwjs:windows" not found.

I looked into it and this error is resolved in nw-builder v3.4.0 but the grunt plugin uses v3.1.1. The code hasn't been updated in 6 years and there is an open PR to update dependencies. For now I'll try using the fork.

Update: The forked package solves the issue.

@ayushmanchhabra
Copy link
Author

ayushmanchhabra commented Feb 12, 2022

I was also thinking about how to distribute desktop builds. According to this Stack Overflow discussion, we could "publish" the builds on every release? I personally haven't tried it yet. Another way could be to host the executables on the website itself or use something like Sourceforge?

Update:
image
I vote to attach the desktop binaries under the release notes.

@ayushmanchhabra ayushmanchhabra closed this as not planned Won't fix, can't repro, duplicate, stale Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant