Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update logic to set 'updatetype' variable in LdaModel.py #1389

Merged
merged 2 commits into from
Jun 5, 2017
Merged

Update logic to set 'updatetype' variable in LdaModel.py #1389

merged 2 commits into from
Jun 5, 2017

Conversation

chinmayapancholi13
Copy link
Contributor

This PR updates the logic to set updatetype variable used in ldamodel.py. Now, we have 3 modes for training the model : online (single-pass), online (multi-pass) and batch.

@chinmayapancholi13
Copy link
Contributor Author

@tmylk I have changed the logic for setting the variable updatetype. Instead of adding a new variable (like streamingtype), I have made changes to the same variable (i.e. updatetype) so that no logging changes are needed.

@menshikh-iv
Copy link
Contributor

Thanks @chinmayapancholi13

@menshikh-iv menshikh-iv merged commit 3e3150c into piskvorky:develop Jun 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chinmayapancholi13 @menshikh-iv