Newlines are now ignored while splitting by sentences in summarizing. Fix #1575. #1590
Conversation
| Associated Press Writer | ||
| SANTO DOMINGO, Dominican Republic (AP) | ||
| AP880911-0016. | ||
| AP-NR-09-11-88 0423EDT r i. |
There was a problem hiding this comment.
Without dots, this doesn't work? You think that this is a good solution?
There was a problem hiding this comment.
Not really, but this was reported in #1575 and I created this PR as an improvement in performance over #1577.
I do believe that we should at least write about this behavior in the docstring. What do you think @menshikh-iv?
There was a problem hiding this comment.
Please check how works summarization notebook with the current dev (It seems that it will not work) + your PR (merge dev to your current branch, install gensim and run notebook).
About docstring - of course, we should describe this behavior.
|
Ping @fbarrios, how is going? |
|
ping @fbarrios, what's status here? |
|
Sorry @menshikh-iv, I've been busy this week. I'll look into this in the next few days. |
|
Ping @fbarrios |
|
@menshikh-iv I think the correct behaviour is the current one, so this PR should be closed, so please do if you agree. I created #1702 for updating the docstring with the current behaviour. |
This is an improvement over #1577 for fixing #1575, as this doesn't need to process all text at once for removing newlines.