Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inference for new unseen author for gensim.models.AuthorTopicModel #1766

Merged
merged 24 commits into from
Mar 26, 2018
Merged

Add inference for new unseen author for gensim.models.AuthorTopicModel #1766

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
f68dfe9
Add function get_new_author_topics() to infer topics distribution for…
Stamenov Dec 6, 2017
2843d1b
Fixes for pep8 compliance. Concrete exception handling.
Stamenov Dec 7, 2017
92ef759
small docstring fix
Stamenov Dec 7, 2017
ee51f71
dont extend self.corpus
Stamenov Dec 28, 2017
2de1b34
pep8 fixes
Stamenov Jan 2, 2018
cbe9049
remove chunksize limitation and small fix
Stamenov Feb 10, 2018
a94c0b1
pep8 fix
Stamenov Feb 10, 2018
783a585
try pep8 fix
Stamenov Feb 11, 2018
3849711
Merge remote-tracking branch 'upstream/develop' into feature/inferenc…
menshikh-iv Feb 12, 2018
a85563b
convert docstring to numpy-style
menshikh-iv Feb 12, 2018
5eb84ff
fix PEP8
menshikh-iv Feb 12, 2018
7df7065
fix major bug
Stamenov Feb 22, 2018
f818bf2
fix pep8
Stamenov Feb 22, 2018
8c5765f
fix merge
Stamenov Feb 23, 2018
5ad9a0b
add tests for get_new_author_topics
Stamenov Feb 23, 2018
8e4899c
fix stash changes
Stamenov Feb 23, 2018
10ba9c8
fix test pep8
Stamenov Feb 23, 2018
0a3eedb
fix exception catching and rollback
Stamenov Feb 26, 2018
f587596
add test for topic similarity
Stamenov Feb 26, 2018
1bc929c
fix pep8
Stamenov Feb 27, 2018
6085b90
some last cosmetic changes
Stamenov Mar 21, 2018
34f5222
author id fix
Stamenov Mar 21, 2018
6d7141d
add tutorial for authorship prediction
Stamenov Mar 25, 2018
c525845
add ipynb
Stamenov Mar 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions gensim/models/atmodel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -940,7 +940,11 @@ def get_new_author_topics(self, corpus, minimum_probability=None):
"""
# TODO: how should this function look like for get_new_author_topics?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's about this TODO?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I mentioned I am iteration over a few versions for the function and will commit the best performing.
It was already discussed here that it is not clear how we should implement this one.

def rho():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Stamenov @olavurmortensen Please document the rationale behind this definition of rho.
Why didn't you write return pow(self.offset + 2 , -self.decay)?
In an earlier version this was return pow(self.offset + 1, -self.decay).
Could you provide any hint?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a different place you explain rho as following:
https://github.com/RaRe-Technologies/gensim/blob/75dce4b50174b5a1afb37b163b903f7e2af903b0/gensim/models/atmodel.py#L812-L816

<<<<<<< Updated upstream
return pow(self.offset + 1 + 1, -self.decay)
=======
return pow(self.offset + 1, -self.decay)
>>>>>>> Stashed changes
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D'oh!


# Wrap in fuction to avoid code duplication.
def rollback_new_author_chages():
Expand Down