Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "downloads" badge to README #2772

Merged
merged 9 commits into from
Apr 22, 2020
Merged

Add "downloads" badge to README #2772

merged 9 commits into from
Apr 22, 2020

Conversation

piskvorky
Copy link
Owner

@piskvorky piskvorky commented Mar 22, 2020

Trying the idea from piskvorky/smart_open#440.

Motivation

In general, seeing how much others use a package improves confidence in its robustness and maintenance. A kind of social proof.

I see no downsides, except if the service that provides this badge (https://pepy.tech/) proves unstable or unreliable.

Badges for gitter and wheels seem useless, so I removed them.

Checklist

Before you create the PR, please make sure you have:

  • Picked a concise, informative and complete title
  • Clearly explained the motivation behind the PR
  • Linked to any existing issues that your PR will be solving
  • Included tests for any new functionality
  • Checked that all unit tests pass

@piskvorky
Copy link
Owner Author

@mpenkov unrelated, but the "build" badge on the main page is red now, failing.

@piskvorky piskvorky requested a review from mpenkov March 22, 2020 18:11
@piskvorky
Copy link
Owner Author

piskvorky commented Mar 22, 2020

I'm also considering removing the "Anaconda Cloud" badge; WDYT?

It's still crowded up there, and this one seems near-useless (and out of our control).

@piskvorky
Copy link
Owner Author

piskvorky commented Apr 22, 2020

@mpenkov ready to merge! CC @gojomo @menshikh-iv do you see anything else vital enough to be communicated in a badge on very top of our README?

@gojomo
Copy link
Collaborator

gojomo commented Apr 22, 2020

If you wanted to drive more usage/support-traffic to Gitter, I could see that badge making sense, but not sure that's a goal.

If you wanted to more generally show affiliations with, or usages of, many other projects/tech as a sort of broad-community-spirit signal, I could see adding more - but probably at a separate section at the bottom, or else they'd dilute the importance/usefulness of the top few. Not important though.

@piskvorky
Copy link
Owner Author

Gensim's Gitter is a ghost town. At least I never go there… I wonder if anyone does.

@menshikh-iv
Copy link
Contributor

Looks fine

I'm also considering removing the "Anaconda Cloud" badge; WDYT?

Not sure than this needed, many persons use them, but up to you.

It's still crowded up there, and this one seems near-useless (and out of our control).

Not true, we control them via conda-forge/gensim-feedstock#43

BTW don't forget to merge the latest develop to your branch (before merging PR), looks like you branched from an old (broken) commit

@piskvorky
Copy link
Owner Author

Thanks for the heads up – develop merged.

@piskvorky piskvorky merged commit ca726c6 into develop Apr 22, 2020
@piskvorky piskvorky deleted the piskvorky-patch-1 branch April 22, 2020 21:09
@piskvorky piskvorky mentioned this pull request Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants