-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove wrappers and other cruft #2972
Conversation
Thanks! Can you add a summary into the Migration wiki too please? So I don't forget to describe it. |
Aaaah, here it is. This PR wasn't labeled as "Milestone 4.0" nor linked to its issue #2852, so I couldn't find it. But I knew there was more :)
Yes, for sure. My dilemma is that I'm not sure whether I dislike some modules simply because I never used them (~NIH), or because they're objectively useless / poor. Although my intuition leans heavily toward the latter. Problematic modules by their mailing list activity:
I'm not sure, would have to take a closer look. CC @gojomo any candidates from your POV? |
This file relies on wrappers that aren't there anymore.
From my point of view, the problem is that I don't have a full understanding of what needs to go and what needs to stay. Once that gets decided, I can execute relatively quickly. Of course, making the big decision is the hardest part of this task. |
OK. Not blocking for 4.0.0beta. |
Removed
gensim/models/wrappers
, associated tests and documentation entirely.Removed
gensim/sklearn_api
entirely.Removed simserver.rst - seems like something really ancient (e.g. https://radimrehurek.com/gensim/simserver.html).
@piskvorky Some questions: