-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement shrink_windows
argument for Word2Vec.
#3169
Merged
Merged
Changes from 11 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
6afb3ff
Implemented `reduced_windows` argument for Word2Vec.
pandrey-fr 9bdb5a1
Improve the way `reduced_windows` is passed around and used.
pandrey-fr 77698cd
Renamed `reduced_windows` to `shrink_windows`.
pandrey-fr 11a464f
Removed `shrink_windows` argument from `Word2Vec.train`.
pandrey-fr 7b6e73a
Merge branch 'develop' into fixed-winsize
M-Demay a657518
Aesthetic fix.
pandrey-fr ff0d30e
Fixed old word2vec models' reloading.
pandrey-fr f98eb43
Fixed undue docstring.
pandrey-fr 3b27f1c
Added `shrink_windows` argument to Doc2Vec.
pandrey-fr 27a49d7
Added `shrink_windows` argument to FastText.
pandrey-fr 6fde7e8
Fixed and optimized `shrink_windows` backend use.
pandrey-fr 486b3f5
Added tests for `shrink_windows=False` in Word2Vec-based models.
pandrey-fr f0af84e
Added docstring mentions of `shrink_window` being experimental.
pandrey-fr 49cf50e
Rolled back some purely aesthetic changes.
pandrey-fr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit repetitive.
Wouldn't it be better to define a model.initialize_reduced_windows method that does this, and call it when needed?
That way, if we find a logic error in the initialization code, we don't have to remember to fix it in a half a dozen other places (e.g. https://github.com/RaRe-Technologies/gensim/pull/3169/files#r649243075).
We should probably also do a bounds check on c.reduced_windows to ensure that it's at least document_len elements long.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with you on the potential for refactored code that would ease future maintenance and updates. That being said, I actually built on the existing, repetitive code, so in my humble opinion this could be handled as a distinct PR (this one would add a feature, while a second one would enhance the validated, working code).
I also think that your suggestion of a
model.initialize_reduced_windows
is not entirely suitable here:If I am not mistaken, in this code,
c
is notmodel
: it is a special C structure (of a different class depending on the trained model class: word2vec, doc2vec or fasttext), and thereduced_windows
PyArray is initialized to have the proper size, so there should not be a need to do a bounds check.I do not know how we could implement a common method (or function) that would also fill the array with either deterministic or random values; but I do agree with you that it could be worth it.
To be honest I lack experience with cython, so that I do not feel entirely at ease with diving into this refactoring. I am willing to give it a try at some point if you want, but would prefer it to be a distinct effort (and PR) from the current one - partly because Mathis and I are pushing the
shrink_windows
feature due to our needing it for a current research project at work, while contributing to refactoring the code base would be something I would (willingly) do on my time off.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alas, there's a lot of pre-existing cut & paste duplication between all these related algorithms & modes that could be refactored. I think that'd be OK to note-and-defer-for-later, as either an issue or a FIXME comment in the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, we can deal with this separately.