Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin scipy in installation requirements as well to fix failing tests #3547

Closed
wants to merge 1 commit into from

Conversation

Crosswind
Copy link

@mpenkov I did some digging to try and understand why the tests started failing suddenly. The important difference is that the successful builds were running the tests against scipy==1.13.1. This is because the version isn't pinned inside setup.py.

This completes the version pinning of scipy started in afbb82e

The tests are currently failing because the build system runs the test against scipy==1.14.0 which doesn't have the required sparsetools (csc_matvecs, specifically) anymore. This commit makes sure that gensim also doesn't test against a version higher than 1.13.1.

Fixes #3544

This completes the version pinning of scipy started in afbb82e

The tests are currently failing because the build system runs the test against scipy==1.14.0 which doesn't have the required sparsetools (csc_matvecs, specifically) anymore. This commit makes sure that gensim also doesn't test against a version higher than 1.13.1.
@Crosswind
Copy link
Author

For those interested on how I got to the conclusion:
I am no expert in building wheels at all but I realized in the workflow logs that for some reason it was still installing scipy 1.14.0 prior to running the tests:

Collecting scipy>=1.7.0 (from gensim==4.3.2.dev0)
    Downloading scipy-1.14.0-cp312-cp312-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (60 kB)
       ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 60.8/60.8 kB 15.3 MB/s eta 0:00:00

The scipy>=1.7.0 got me thinking as I didn't see that in the pyproject.toml. Instead, this is specified in setup.py which is used during the build process.

One potential improvement would be to remove the >=1.7.0 as this is also not specified in pyproject.toml. This could help avoid confusion in the future and I also believe it is unlikely that pip will find itself in a situation where a version such as 1.8.0 is the highest available version.

@Crosswind
Copy link
Author

The same fix is already in #3538 so this can be closed.

@Crosswind Crosswind closed this Jul 18, 2024
@Crosswind Crosswind deleted the patch-1 branch July 18, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gensim package import issues
1 participant