Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG] Topic Coherence #750

Merged
merged 10 commits into from
Jul 5, 2016
Merged

[MRG] Topic Coherence #750

merged 10 commits into from
Jul 5, 2016

Conversation

devashishd12
Copy link
Contributor

@devashishd12 devashishd12 commented Jun 23, 2016 •
edited
Loading

This PR is being used for further work on the topic coherence pipeline. Changes made:

  • Added LdaVowpalWabbit example to notebook.
  • Added LdaMallet support and example to notebook
  • Made minor changes to documentation and code in coherencemodel.
  • Added test suite for coherencemodel and aggregation.
  • Added 'topics' parameter to coherencemodel. Can now provide tokenized topics to calculate coherence value

@tmylk tmylk changed the title Added vowpalwabbit wrapper to notebook. [WIP] Topic Coherence. Added vowpalwabbit wrapper to notebook. Jun 24, 2016
@devashishd12 devashishd12 changed the title [WIP] Topic Coherence. Added vowpalwabbit wrapper to notebook. [WIP] Topic Coherence Jun 24, 2016
@devashishd12
Copy link
Contributor Author

@tmylk LdaMallet support has been added. Notebook has been updated.

@devashishd12
Copy link
Contributor Author

@tmylk @piskvorky could you please start the review process for the topic coherence pipeline? I'll start preparing for benchmark testing now.

@devashishd12 devashishd12 changed the title [WIP] Topic Coherence [MRG] Topic Coherence Jun 24, 2016
@tmylk
Copy link
Contributor

tmylk commented Jun 28, 2016

Needs a CHANGELOG

@devashishd12 devashishd12 force-pushed the topic_coherence_work branch from d9da2c9 to b1b4963 Compare June 28, 2016 17:59
@devashishd12
Copy link
Contributor Author

@tmylk added changelog entry.

@devashishd12 devashishd12 force-pushed the topic_coherence_work branch 2 times, most recently from 8e1b279 to afa0b41 Compare June 29, 2016 19:27
@devashishd12
Copy link
Contributor Author

Still working on the tests. Have to modify them.

@devashishd12 devashishd12 changed the title [MRG] Topic Coherence [WIP] Topic Coherence Jun 30, 2016
piskvorky
piskvorky reviewed Jun 30, 2016
View reviewed changes
CHANGELOG.md
@@ -22,7 +23,7 @@ Changes
* SparseMatrixSimilarity returns a sparse matrix if `maintain_sparsity` is True (@davechallis, #590)
* added functionality for Topics of Words in document - i.e, dynamic topics. (@bhargavvader, #704)
- also included tutorial which explains new functionalities, and document word-topic colring.
* Made normalization an explicit transformation. Added 'l1' norm support (@squareindia, #649)
* Made normalization an explicit transformation. Added 'l1' norm support (@dsquareindia, #649)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add these references as hyperlinks -- we're using markdown now in CHANGELOG.

@bhargavvader bhargavvader mentioned this pull request Jul 1, 2016
Merged
@devashishd12 devashishd12 force-pushed the topic_coherence_work branch from e8dcdb1 to ad22da5 Compare July 1, 2016 11:05
@devashishd12 devashishd12 changed the title [WIP] Topic Coherence [MRG] Topic Coherence Jul 1, 2016
@devashishd12
Copy link
Contributor Author

@tmylk I've modified the tests. They pass now.

@devashishd12 devashishd12 changed the title [MRG] Topic Coherence [WIP] Topic Coherence Jul 1, 2016
@devashishd12
Copy link
Contributor Author

devashishd12 commented Jul 1, 2016 •
edited
Loading

Please don't merge yet. I'll add some more documentation for the new feature of providing tokenized topics and will also add sanity checks for checking if LdaModel, LdaMallet and LdaVowpalWabbit work.

@devashishd12 devashishd12 changed the title [WIP] Topic Coherence [MRG] Topic Coherence Jul 1, 2016
@devashishd12
Copy link
Contributor Author

Test suite for coherencemodel is complete. @tmylk could you please review?

@tmylk tmylk merged commit ff3adb8 into piskvorky:develop Jul 5, 2016
@devashishd12 devashishd12 deleted the topic_coherence_work branch September 30, 2016 06:09
@devashishd12
Copy link
Contributor Author

Linking to #710.

@devashishd12 devashishd12 mentioned this pull request Oct 3, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devashishd12 @tmylk @piskvorky