Keyedvecs updates #852
Closed
Keyedvecs updates #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayantj
force-pushed
the
keyedvecs_updates
branch
from
c916c60 to
dccb7e3
Compare
jayantj
force-pushed
the
keyedvecs_updates
branch
from
dccb7e3 to
5a3676c
Compare
jayantj
force-pushed
the
keyedvecs_updates
branch
from
5a3676c to
7cffdfc
Compare
|
It's be easier to keep this continuation-work (and comments) on #833. |
|
Yep, I need write access to @droudy's fork though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extension of #833, related to #847
syn0,syn0norm,vocab,index2word. They are a little verbose, and there's some code duplication, but this seems to be the most principled way to handle backwards compatibility.@gojomo @droudy please have a look