fix(swagger/security): ensure that the requested file is in the UI directory #1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rectory The Rest::Swagger class didn't check if the file asked from the user was contained in the UI directory, thus allowing users to access arbitrary files in the filesystem. Thanks to Kirill Efimov (@Kirill89) and the Snyk Security team for finding and reporting the vulnerability to the Pistache team.
|
abidiff reports a potential ABI change, but that's probably related to the inclusion of Edit: they seem template instantiations |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Rest::Swaggerclass didn't check if the file asked from the user was contained in the UI directory, thus allowing users to access arbitrary files in the filesystem.Thanks to Kirill Efimov (@Kirill89) and the Snyk Security team (@snyk) for finding and reporting the vulnerability to the Pistache team.
Closes #1064