Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NEW FEATURE #29

Merged
merged 35 commits into from
Oct 18, 2022
Merged

NEW FEATURE #29

merged 35 commits into from
Oct 18, 2022

Conversation

pitzzahh
Copy link
Owner

fix on issue [#28]

pitzzahh added 30 commits October 17, 2022 19:19
Update dependencies version
7fa3bd7
Exclude junit dependency
f3a1385
fix import statements on new util-classes directory
6484450
Added setters for Client fields
884a444
made Consumer<DataSource> setDataSource() as a default method.
5ecdf60
removed accidental 's' letter on getAllLoans() comment
4bc223f
Add custom exception for non-found clients
2a7d6b0
Renamed AtmDAOImplementation class to InDatabase
44be8a0
Renamed AtmDAOImplementation to InDatabase
3e0ca02
Added comments in mutator methods
2b92ec9
changed Function<String, Map<String, List<Message>>> getMessage() met…
0462d00 
…hod to default
Add InMemory Database
74adde6
Removed Function<String, Map<String, List<Message>>> getMessage() fun…
528dffd 
…ction, will rely on the default function in AtmDao
Added mutator functions for Loan fields.
88f7a87
Added approve(), decline(), and removeLoan() method implementations
ba15c80
Added afterAll() method
f20e9ac
Added empty test for InMemory Database
436cd8d
moved from database folder to dao folder
5319640
moved to same folder dao
f03a07b
renamed class from InDatabaseAtmServiceTest to InDatabaseTest
30b9bc7
Util class that is used for testing
bc7460e
renamed Person import to Util
9a8a99b
renamed class from InMemoryAtmServiceTest to InMemoryTest
907507a
removed
31ce31e
added postgresql dependency and excluded
e2a6558
added custom class LoanDoesNotExist
fbec9cb
removed AtmDao import
ebb6b0d
refactor else thrown exception
ab3a7e5
refactor Function<Loan, Status> requestLoan() method body
026aa83
replaced repeated tests with normal test [FAILING TESTS]
a9130eb
@pitzzahh pitzzahh added the enhancement New feature or request label Oct 18, 2022
@pitzzahh pitzzahh merged commit cb6772b into main Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pitzzahh