-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Associate existing subnet GUIDs when configuring director networks #559
Conversation
We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story. The labels on this github issue will be updated when the story is started. |
func (a Api) addGUIDToExistingSubnet(network *Network, existingNetwork *Network) []Subnet { | ||
for k, subnet := range network.Subnets { | ||
for _, existingSubnet := range existingNetwork.Subnets { | ||
if subnet.CIDR == existingSubnet.CIDR { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if the comparison should be made on more fields. In theory it does not really matter since the other field would be updated.
* cherry-picking code from forked repo * #559 Co-authored-by: Mark Stokan <stokanm@vmware.com> Co-authored-by: claire tinati <ctinati@vmware.com>
In my case, when the az configuration is:
and will meet error when staging back the director configuration:
This change doesn't work to fix the problem. But I can use this change to simple fix my problem: https://gitlab.eng.vmware.com/PKS/gear2/-/commit/28838ed57a3edf699ea1e619c0bc45d363df00a2, not sure if you guys can open it. |
Closing due to age. If this is still needed, please resubmit. |
Ref #558