Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to specify separate UAA Host for local dev #581

Closed
wants to merge 2 commits into from

Conversation

nouseforaname
Copy link

@nouseforaname nouseforaname commented Jan 14, 2022

Hey I'm from the BOSH/OpsMan Team

We'd like to allow to reset uaa host to a value from an env var.

In local dev envs we do not always have nginx or another lb to do
path based routing and therefore possibly run UAA on a different port.

Currently this blocks os from using om to setup local OpsMan configs for testing (e.g. we add stuff)

I opted to not expose that as a flag to avoid customer iritation about the possibility of resetting
the UAA Host since that should not really be necessary for other purposes than engineering.

If you need me to add tests for this let me know.

allow to reset uaa host to value from env var. in local dev envs we
do not always have nginx or another lb to do path based routing and
therefore can run UAA on a different port. This is not exposed as a
flag to avoid customer iritation about the possibility of resetting
the UAA Host.
@cf-gitbot
Copy link
Member

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

add test for ENV Var behaviour
@jtarchie
Copy link
Contributor

jtarchie commented Feb 8, 2022

I wouldn't hardcode an environment variable. You can use the structs for commands (and main) to add environment variable only values.

type SomeStruct struct {
UAAHost    string `env:"OM_UAA_HOST" hidden:"true"` 
}

This should be the amount of code you need to accomplish the same thing.

@rhall-pivotal
Copy link
Member

Closing due to age. If this is still needed, please resubmit.
-TAS Operability

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants