Replace deprecated methods usage with alternative methods #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yharish991
changed the title
davewalter
approved these changes
Aug 5, 2024
| @@ -682,7 +682,7 @@ valid options configurations include percentages ('50%'), counts ('2'), and 'def | |||
| // if strings.Contains(req.URL.Path, "some-product-guid") { | |||
| // resp = &http.Response{ | |||
| // StatusCode: http.StatusOK, | |||
| // Body: ioutil.NopCloser(bytes.NewBufferString(`{ | |||
| // Body: io.NopCloser(bytes.NewBufferString(`{ | |||
There was a problem hiding this comment.
This code is commented out. Can it be removed?
There was a problem hiding this comment.
I did see this, but I was not exactly sure what this BeforeEach block, so left it as is. Will address this in a followup PR as this is not in the scope of this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces all Go standard library deprecated methods uswith the recommended alternatives.