-
Notifications
You must be signed in to change notification settings - Fork 91
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(react-dividers): Add react renderers for dividers
[Finishes #84297688] Signed-off-by: Nicole Sullivan <nsullivan@pivotal.io>
- Loading branch information
1 parent
495e09e
commit 07061a3
Showing
4 changed files
with
211 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
'use strict'; | ||
|
||
var React = require('react'); | ||
var _ = require('lodash'); | ||
|
||
var Divider = React.createClass({ | ||
render: function () { | ||
var typeName = "divider"; | ||
var classes = []; | ||
|
||
if (!this.props.inverse) { | ||
typeName += "-alternate" | ||
} | ||
|
||
if (this.props.large) { | ||
typeName += "-2" | ||
} else { | ||
typeName += "-1" | ||
} | ||
|
||
classes.push(typeName); | ||
|
||
if (this.props.className) { | ||
classes.push(this.props.className); | ||
} | ||
|
||
classes = classes.join(" "); | ||
|
||
return ( | ||
<hr {...this.props} className={classes} /> | ||
); | ||
} | ||
}); | ||
|
||
|
||
var DividerInverse = React.createClass({ | ||
render: function () { | ||
return ( | ||
<Divider {...this.props} inverse="true" /> | ||
); | ||
} | ||
}); | ||
|
||
module.exports = { | ||
Divider: Divider, | ||
DividerInverse: DividerInverse | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,105 @@ | ||
'use strict'; | ||
|
||
var $ = require('jquery'); | ||
var React = require('react/addons'); | ||
var TestUtils = React.addons.TestUtils; | ||
|
||
var Divider = React.createFactory(require('../../../src/pivotal-ui/javascripts/dividers.jsx').Divider); | ||
|
||
describe('Divider', function() { | ||
beforeEach(function() { | ||
this.node = $('<div id="container"></div>').appendTo('body').get(0); | ||
|
||
React.render( | ||
Divider({}), | ||
this.node | ||
); | ||
}); | ||
|
||
afterEach(function() { | ||
React.unmountComponentAtNode(this.node); | ||
document.body.removeChild(this.node); | ||
}); | ||
|
||
it("creates a divider", function() { | ||
expect($('#container hr')).toHaveClass('divider-alternate-1'); | ||
}); | ||
|
||
describe("when large is set to true", function() { | ||
beforeEach(function() { | ||
React.render( | ||
Divider({ | ||
large: "true" | ||
}), | ||
this.node | ||
); | ||
}); | ||
|
||
it("creates a divider with -2 appended to the classname", function() { | ||
expect($('#container hr')).toHaveClass('divider-alternate-2'); | ||
}); | ||
}); | ||
|
||
describe("when the divider goes on a dark background, inverse: true", function() { | ||
beforeEach(function() { | ||
React.render( | ||
Divider({ | ||
inverse: "true" | ||
}), | ||
this.node | ||
); | ||
}); | ||
|
||
it("creates a divider without the -alternate in the class", function() { | ||
expect($('#container hr')).toHaveClass('divider-1'); | ||
}); | ||
}); | ||
|
||
describe("when a large divider goes on a dark background, inverse: true", function() { | ||
beforeEach(function() { | ||
React.render( | ||
Divider({ | ||
inverse: "true", | ||
large: "true" | ||
}), | ||
this.node | ||
); | ||
}); | ||
|
||
it("creates a divider without the -alternate in the class", function() { | ||
expect($('#container hr')).toHaveClass('divider-2'); | ||
}); | ||
}); | ||
|
||
describe("setting a custom className", function() { | ||
beforeEach(function() { | ||
React.render( | ||
Divider({ | ||
inverse: "true", | ||
className: "myClass" | ||
}), | ||
this.node | ||
); | ||
}); | ||
|
||
it("passes the class through to the divider", function() { | ||
expect($('#container hr')).toHaveClass('divider-1'); | ||
expect($('#container hr')).toHaveClass('myClass'); | ||
}); | ||
}); | ||
|
||
describe("setting a custom data attribute", function() { | ||
beforeEach(function() { | ||
React.render( | ||
Divider({ | ||
"data-behavior": "myAttr" | ||
}), | ||
this.node | ||
); | ||
}); | ||
|
||
it("passes the data attribute through to the divider", function() { | ||
expect($('#container hr').attr('data-behavior')).toEqual('myAttr'); | ||
}); | ||
}); | ||
}); |