fix(modal): Modals regain their fly-in behavior

[Fixes #94552398] Signed-off-by: Geoff Pleiss <gpleiss@pivotallabs.com>
pivotal-cf · May 18, 2015 · 1704b41 · 1704b41
1 parent 726fbb8
commit 1704b41
Show file tree

Hide file tree

Showing 6 changed files with 25 additions and 26 deletions.
diff --git a/src/bootstrap/package.json b/src/bootstrap/package.json
@@ -1,7 +1,7 @@
 {
   "name": "pui-css-bootstrap",
   "style": "bootstrap.css",
-  "version": "0.0.2",
+  "version": "0.0.3",
   "description": "Custom build of Bootstrap for Pivotal UI",
   "repository": {
     "type": "git",

diff --git a/src/pivotal-ui/components/modals/modals.scss b/src/pivotal-ui/components/modals/modals.scss
@@ -1,4 +1,24 @@
 @import "../pui-variables";
+@import '../mixins';
+@import "../../../../node_modules/bootstrap-sass/assets/stylesheets/bootstrap/mixins";
+@import "../../../../node_modules/bootstrap-sass/assets/stylesheets/bootstrap/modals";
+
+.modal-fade-enter, .modal-fade-leave {
+  @extend .fade;
+
+  //Base .fade styles from bootstrap
+  @include transition(opacity .15s linear);
+  opacity: 0;
+}
+
+//Class created in React Animations
+.modal-fade-enter-active {
+  @extend .in;
+
+  //Base .in styles from bootstrap
+  opacity: 1;
+}
+
 
 /*doc
 ---

diff --git a/src/pivotal-ui/components/modals/package.json b/src/pivotal-ui/components/modals/package.json
@@ -1,8 +1,7 @@
 {
-  "version": "0.0.6",
+  "version": "0.0.7",
   "homepage": "http://styleguide.pivotal.io/objects.html#modal",
   "dependencies": {
-    "pui-css-bootstrap": "*",
-    "pui-css-react-animations": ">=0.0.3"
+    "pui-css-bootstrap": "*"
   }
 }
diff --git a/src/pivotal-ui/components/react-animations/package.json b/src/pivotal-ui/components/react-animations/package.json
@@ -1,5 +1,5 @@
 {
   "homepage": "http://styleguide.pivotal.io",
   "dependencies": {},
-  "version": "0.0.3"
+  "version": "0.0.4"
 }
diff --git a/src/pivotal-ui/components/react-animations/react-animations.scss b/src/pivotal-ui/components/react-animations/react-animations.scss
@@ -2,26 +2,6 @@
 @import '../mixins';
 @import "../../../../node_modules/bootstrap-sass/assets/stylesheets/bootstrap/mixins";
 
-//Bootstrap
-%fade {
-  opacity: 0;
-  @include transition(opacity .15s linear);
-  &.in {
-    opacity: 1;
-  }
-}
-
-.fade-enter {
-  @extend %fade;
-
-  &-active {
-    @extend %fade.in;
-  }
-}
-
-.fade-leave {
-  @extend %fade;
-}
 
 .new-enter {
   -webkit-animation: new-item-grow .3s cubic-bezier(0.895, 0.03, 0.685, 0.22) forwards, new-item-fade .5s ease-in .15s forwards;

diff --git a/src/pivotal-ui/frameworks/bootstrap-sass-v3.2.0.scss b/src/pivotal-ui/frameworks/bootstrap-sass-v3.2.0.scss
@@ -41,7 +41,7 @@
 @import "../../../node_modules/bootstrap-sass/assets/stylesheets/bootstrap/close";
 
 // Components w/ JavaScript
-@import "../../../node_modules/bootstrap-sass/assets/stylesheets/bootstrap/modals";
+//@import "../../../node_modules/bootstrap-sass/assets/stylesheets/bootstrap/modals";
 //@import "../../../node_modules/bootstrap-sass/assets/stylesheets/bootstrap/tooltip";
 //@import "../../../node_modules/bootstrap-sass/assets/stylesheets/bootstrap/popovers";
 //@import "../../../node_modules/bootstrap-sass/assets/stylesheets/bootstrap/carousel";